Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correction of comma #5347

Merged
merged 1 commit into from
Dec 22, 2021
Merged

correction of comma #5347

merged 1 commit into from
Dec 22, 2021

Conversation

yogender26
Copy link
Contributor

you do not need a comma if the clause comes at the end of the sentence. This applies to all subordinate clauses, not just. should i merg ?

@scrapy scrapy deleted a comment from tobetterman Dec 7, 2021
@scrapy scrapy deleted a comment from coldplaykawei Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #5347 (60de016) into master (c316ca4) will not change coverage.
The diff coverage is n/a.

❗ Current head 60de016 differs from pull request most recent head 9be42d2. Consider uploading reports for the commit 9be42d2 to get more accurate results

@@           Coverage Diff            @@
##           master    #5347    +/-   ##
========================================
  Coverage   88.59%   88.59%            
========================================
  Files         163      163            
  Lines       10616    10616            
  Branches     1558     1807   +249     
========================================
  Hits         9405     9405            
  Misses        936      936            
  Partials      275      275            
Impacted Files Coverage Δ
scrapy/commands/__init__.py 67.60% <ø> (ø)

@Gallaecio Gallaecio merged commit d6a384b into scrapy:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants