Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command parse unhandled error :AttributeError: 'NoneType' object has no attribute 'start_requests'(#3264) #5376

Closed
wants to merge 2 commits into from

Conversation

rahul-sambyal
Copy link

@rahul-sambyal rahul-sambyal commented Jan 22, 2022

Reopening @wangrenlei's PR
Fixes #3264

@rahul-sambyal rahul-sambyal marked this pull request as ready for review January 22, 2022 09:12
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #5376 (837038d) into master (92764d6) will decrease coverage by 0.46%.
The diff coverage is 91.89%.

❗ Current head 837038d differs from pull request most recent head e7ccec1. Consider uploading reports for the commit e7ccec1 to get more accurate results

@@            Coverage Diff             @@
##           master    #5376      +/-   ##
==========================================
- Coverage   88.58%   88.11%   -0.47%     
==========================================
  Files         163      163              
  Lines       10635    10628       -7     
  Branches     1812     1810       -2     
==========================================
- Hits         9421     9365      -56     
- Misses        938      985      +47     
- Partials      276      278       +2     
Impacted Files Coverage Δ
scrapy/commands/parse.py 20.11% <0.00%> (-0.12%) ⬇️
scrapy/http/response/text.py 100.00% <ø> (ø)
scrapy/downloadermiddlewares/stats.py 91.66% <91.66%> (-0.93%) ⬇️
scrapy/exporters.py 100.00% <100.00%> (ø)
scrapy/extensions/feedexport.py 91.23% <100.00%> (-3.85%) ⬇️
scrapy/item.py 98.36% <100.00%> (-0.39%) ⬇️
scrapy/settings/__init__.py 93.06% <100.00%> (+0.08%) ⬆️
scrapy/spiders/feed.py 73.84% <100.00%> (+7.69%) ⬆️
scrapy/utils/misc.py 97.72% <100.00%> (ø)
scrapy/utils/response.py 90.19% <100.00%> (+0.40%) ⬆️
... and 13 more

@rahul-sambyal
Copy link
Author

Hey @wRAR, I am new to this, in fact this is my first PR. Is there something else I need to do here? Thanks.

@Gallaecio
Copy link
Member

Ideally, the pull requests should pass all tests, and if not you should find out why and address any issue.

It is possible that some of the broken tests are unrelated to your changes though. Let me close and reopen the pull request to re-trigger the tests, and see if they pass.

@Gallaecio Gallaecio closed this Feb 8, 2022
@Gallaecio Gallaecio reopened this Feb 8, 2022
@wRAR
Copy link
Member

wRAR commented Feb 10, 2022

The tests indeed fail for different reasons but this code is not covered by tests. I think it shouldn't be hard to make a test that runs the failing command (even though all existing tests in test_command_parse.py pass --spider explicitly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command parse unhandled error :AttributeError: 'NoneType' object has no attribute 'start_requests'
4 participants