Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError on using pathlib.Path as key on FEEDS settings #5384

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Fix TypeError on using pathlib.Path as key on FEEDS settings #5384

merged 3 commits into from
Feb 4, 2022

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Jan 31, 2022

Closes #5383

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #5384 (c286bec) into master (30d5779) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5384      +/-   ##
==========================================
- Coverage   88.59%   88.41%   -0.19%     
==========================================
  Files         163      163              
  Lines       10649    10651       +2     
  Branches     1816     1816              
==========================================
- Hits         9435     9417      -18     
- Misses        938      957      +19     
- Partials      276      277       +1     
Impacted Files Coverage Δ
scrapy/settings/__init__.py 93.06% <100.00%> (+0.08%) ⬆️
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

@Gallaecio Gallaecio merged commit fe43411 into scrapy:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error when we try to retrieve the FEEDS setting via CLI and it has a Path objects as a key
3 participants