Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csviter call, add parse_rows test #5394

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix csviter call, add parse_rows test #5394

merged 1 commit into from
Feb 8, 2022

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Feb 5, 2022

Closes #5391

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #5394 (775107b) into master (b282a7a) will decrease coverage by 4.24%.
The diff coverage is 100.00%.

❗ Current head 775107b differs from pull request most recent head db83e49. Consider uploading reports for the commit db83e49 to get more accurate results

@@            Coverage Diff             @@
##           master    #5394      +/-   ##
==========================================
- Coverage   88.54%   84.30%   -4.25%     
==========================================
  Files         163      163              
  Lines       10627    10627              
  Branches     1809     1807       -2     
==========================================
- Hits         9410     8959     -451     
- Misses        941     1406     +465     
+ Partials      276      262      -14     
Impacted Files Coverage Δ
scrapy/spiders/feed.py 73.84% <100.00%> (+7.69%) ⬆️
scrapy/utils/asyncgen.py 33.33% <0.00%> (-66.67%) ⬇️
scrapy/core/http2/stream.py 27.01% <0.00%> (-64.37%) ⬇️
scrapy/pipelines/images.py 27.82% <0.00%> (-62.61%) ⬇️
scrapy/core/http2/agent.py 36.14% <0.00%> (-60.25%) ⬇️
scrapy/core/downloader/handlers/http2.py 43.42% <0.00%> (-56.58%) ⬇️
scrapy/core/http2/protocol.py 34.17% <0.00%> (-49.25%) ⬇️
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️
scrapy/utils/test.py 43.75% <0.00%> (-17.19%) ⬇️
scrapy/utils/ssl.py 53.65% <0.00%> (-17.08%) ⬇️
... and 10 more

@wRAR wRAR mentioned this pull request Feb 7, 2022
@wRAR
Copy link
Member

wRAR commented Feb 7, 2022

Can you please look at the flake8 output?

@Laerte
Copy link
Member Author

Laerte commented Feb 7, 2022

@wRAR Done.

@Gallaecio
Copy link
Member

Closing and reopening to trigger CI jobs rebased on top of #5401.

@Gallaecio Gallaecio closed this Feb 7, 2022
@Gallaecio Gallaecio reopened this Feb 7, 2022
@Gallaecio Gallaecio merged commit 4bda097 into scrapy:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect initialization of csviter in scrapy.spiders.feed.CSVFeedSpider
3 participants