Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running tests with Twisted 22.1.0 #5405

merged 2 commits into from
Feb 8, 2022


Copy link

@wRAR wRAR commented Feb 8, 2022

Fixes #5400, see the explanation there.

I've decided to put the classes into because it already has a resource class and other two files already import from it. But it's possible to move them into a separate file (in which case I'd discuss if we want to keep those supplementary modules in tests/ or move them into a subdir).

Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #5405 (77547a1) into master (fd55f62) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5405      +/-   ##
- Coverage   88.61%   88.44%   -0.17%     
  Files         163      163              
  Lines       10627    10627              
  Branches     1809     1809              
- Hits         9417     9399      -18     
- Misses        935      953      +18     
  Partials      275      275              
Impacted Files Coverage Δ
scrapy/ 75.30% <0.00%> (-22.23%) ⬇️

Copy link

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I see all errors in tests so far are due to #5404, so feel free to merge if the same applies to pypy3-pinned (which I imagine it will).

@wRAR wRAR merged commit 1356836 into scrapy:master Feb 8, 2022
@wRAR wRAR deleted the tests-twisted-22.1-fix branch February 8, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Tests broken with Twisted 22.1.0
2 participants