Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toscrape.com instead of example.com in test_command_check. #5407

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Feb 10, 2022

Closes: #5404.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #5407 (22cf953) into master (e2e2ffd) will not change coverage.
The diff coverage is n/a.

❗ Current head 22cf953 differs from pull request most recent head 09576d5. Consider uploading reports for the commit 09576d5 to get more accurate results

@@           Coverage Diff           @@
##           master    #5407   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         163      163           
  Lines       10641    10641           
  Branches     1813     1813           
=======================================
  Hits         9447     9447           
  Misses        919      919           
  Partials      275      275           

@Gallaecio Gallaecio merged commit 5d7c0a5 into scrapy:master Feb 10, 2022
@wRAR wRAR deleted the contract-tests-toscrape branch May 8, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/test_command_check.py::CheckCommandTest depends on example.com
2 participants