HTML Conventions #5451
Merged
HTML Conventions #5451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don’t get why, but I have no argument against it either. |
Codecov Report
@@ Coverage Diff @@
## master #5451 +/- ##
=======================================
Coverage 88.77% 88.77%
=======================================
Files 163 163
Lines 10666 10666
Branches 1818 1818
=======================================
Hits 9469 9469
Misses 922 922
Partials 275 275 |
|
Hello, this is my first PR. Is the failure in the tests necessarily an error in the modification I have entered? It seems strange to me because they are very small changes. |
|
Sadly we have a few tests in Scrapy that fail randomly. Do not worry about it. |
Gallaecio
approved these changes
Mar 17, 2022
|
I'm also unsure what's the advantage, but the changes look fine, let's merge them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the HTML files following SonarCloud's recommendations.