Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation update for multiple spiders #5461

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

yash-fn
Copy link
Contributor

@yash-fn yash-fn commented Mar 26, 2022

i noticed passing settings to configure logging function made weird output go away. checked documentation and it says first parameter is settings file. Is this correct?

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #5461 (76291fd) into master (8c3e5a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 76291fd differs from pull request most recent head 319e67f. Consider uploading reports for the commit 319e67f to get more accurate results

@@           Coverage Diff           @@
##           master    #5461   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         163      163           
  Lines       10666    10676   +10     
  Branches     1818     1821    +3     
=======================================
+ Hits         9469     9478    +9     
  Misses        922      922           
- Partials      275      276    +1     
Impacted Files Coverage Δ
scrapy/cmdline.py 67.96% <100.00%> (+1.30%) ⬆️
scrapy/core/engine.py 83.95% <100.00%> (-0.26%) ⬇️
scrapy/crawler.py 88.82% <100.00%> (+0.18%) ⬆️

@Gallaecio
Copy link
Member

Note: This change is targeting the 2.6 branch, but even if the change is correct it is probably best suited for the main branch.

@yash-fn yash-fn changed the base branch from 2.6 to master April 9, 2022 01:32
@yash-fn
Copy link
Contributor Author

yash-fn commented Apr 9, 2022

Sorry. Didn't notice I targeted wrong branch. Changed it as suggested.

@wRAR
Copy link
Member

wRAR commented Apr 12, 2022

It's still based on 2.6 and so contains all new commits from that branch. You need to rebase it onto master.

i noticed passing settings to configure logging function made weird output go away. checked documentation and it says first parameter is settings file. Is this correct?
@yash-fn
Copy link
Contributor Author

yash-fn commented Apr 12, 2022

apologies. I'm garbage at anything beyond basic git. Did I do it correctly this time?

@wRAR
Copy link
Member

wRAR commented Apr 12, 2022

Yes, this looks fine to me

@wRAR wRAR merged commit ded28f7 into scrapy:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants