Deprecate scrapy.pipelines.images.NoimagesDrop #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I don't think |
|
Thanks for your response. Will fix it. |
|
This should work correctly |
PluT00
force-pushed
the
deprecate-NoimagesDrop
branch
from
34d8319 to
9f659bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #5489 +/- ##
==========================================
+ Coverage 88.67% 88.83% +0.16%
==========================================
Files 162 162
Lines 10998 11002 +4
Branches 1801 1801
==========================================
+ Hits 9752 9774 +22
+ Misses 966 948 -18
Partials 280 280
|
|
Hey! Could you tell me please, what should I do with these checks which were cancelled? And what do you think about the solution? @wRAR |
Gallaecio
approved these changes
Nov 5, 2022
wRAR
approved these changes
Nov 5, 2022
This was referenced Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate scrapy.pipelines.images.NoimagesDrop
Resolves #5368