Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update instruction to install using ubuntu packages #549

Merged
merged 3 commits into from Jan 20, 2014

Conversation

@dangra
Copy link
Member

@dangra dangra commented Jan 19, 2014

Implements option (1) from #509 and address issue commented by #511 (comment)

It also uses a new key for signing repository files:

pub   2048R/627220E7 2014-01-18 [expires: 2024-01-16]
uid                  Scrapy Team (APT Signing Key) <info@scrapy.org>

Previous repositories per codename still work, and they are kept uptodate and signed by old key:

pub   2048R/19403F1D 2010-06-10
uid                  Insophia (Scrapy Package Signing Key) <info@insophia.com>
@dangra
Copy link
Member Author

@dangra dangra commented Jan 20, 2014

/cc @pablohoffman @redapple @kmike

review and feel free to merge if fine for you.

For Ubuntu Precise (12.04)::

deb http://archive.scrapy.org/ubuntu precise main
sudo apt-get update sudo apt-get install scrapy-VERSION

This comment has been minimized.

@kmike

kmike Jan 20, 2014
Member

does it work without ;?

This comment has been minimized.

@dangra

dangra Jan 20, 2014
Author Member

good catch, somehow I removed && from that line.


The public GPG key used to sign these packages can be imported into you APT
keyring as follows::
lists first, e.g., with ``apt-get update``.

This comment has been minimized.

@kmike

kmike Jan 20, 2014
Member

I think this warning should be reformulated, because if user followed the previous command apt-get update will do nothing.

This comment has been minimized.

@dangra

dangra Jan 20, 2014
Author Member

any ideas on a replacement for that sentence?

This comment has been minimized.

@kmike

kmike Jan 20, 2014
Member

One idea:

 .. note:: Please note that these packages are updated frequently, so we're
    using ``apt-get update`` to update package list first.

This comment has been minimized.

@dangra

dangra Jan 20, 2014
Author Member

Updating package lists is required for the first time, I think the warning tries to cope with package upgrades.

Nowadays Ubuntu does a better job keeping package lists uptodate automatically, the warning may be more confusing than useful.

what about removing it or go for something like:

.. note:: Please note that these packages are updated frequently. If you are trying 
   to upgrade Scrapy, run ``sudo apt-get update`` to update package list first.

This comment has been minimized.

@dangra

dangra Jan 20, 2014
Author Member

or more clear:

.. note:: Please note that these packages are updated frequently, repeat step 3 If you are trying 
   to upgrade Scrapy.

This comment has been minimized.

@kmike

kmike Jan 20, 2014
Member

I like all your options (including "remove this note").

dangra added a commit that referenced this pull request Jan 20, 2014
[MRG] update instruction to install using ubuntu packages
@dangra dangra merged commit 1c514c5 into scrapy:master Jan 20, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@dangra dangra deleted the dangra:509-scrapy-apt-repo branch Jan 20, 2014
@dangra dangra mentioned this pull request Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants