Issue #3264, fix error handling when spider is not matched #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Implementation: - Check whether Spider exists or is None, and if it's None skip execution of start_requests() with non existing Spider Testing: - Add a test case with invalid url inside test_command_parse Test proves that non-matched Spider does not throw an AttributeError
Gallaecio
reviewed
May 14, 2022
| @@ -222,6 +223,10 @@ def test_crawlspider_no_matching_rule(self): | |||
| self.assertRegex(_textmode(out), r"""# Scraped Items -+\n\[\]""") | |||
| self.assertIn("""Cannot find a rule that matches""", _textmode(stderr)) | |||
|
|
|||
| status, out, stderr = yield self.execute([self.url('/invalid_url')]) | |||
There was a problem hiding this comment.
Please, give this test its own test method instead of running it within the existing test_crawlspider_no_matching_rule.
There was a problem hiding this comment.
Thanks @Gallaecio , should I use also the decorator @defer.inlineCallbacks in my new test?
Codecov Report
@@ Coverage Diff @@
## master #5497 +/- ##
==========================================
+ Coverage 88.58% 88.74% +0.15%
==========================================
Files 163 163
Lines 10666 10671 +5
Branches 1818 1819 +1
==========================================
+ Hits 9449 9470 +21
+ Misses 941 926 -15
+ Partials 276 275 -1
|
|
Thanks @andreastziortz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implementation:
Testing:
Test proves that non-matched Spider does not throw an AttributeError
Fixes #3264, resolves #5376