Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass on item to thumb_path function as additional argument #5508

Merged
merged 4 commits into from
Jun 4, 2022

Conversation

mtabbasi
Copy link
Contributor

Fixes #5504

@mtabbasi mtabbasi changed the title pass on item to thumb_path function as additional argument resolves #… pass on item to thumb_path function as additional argument May 24, 2022
@wRAR
Copy link
Member

wRAR commented May 24, 2022

Can you please take a look at #4686 and update your PR accordingly?

@mtabbasi
Copy link
Contributor Author

mtabbasi commented May 24, 2022

Sure

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #5508 (7a686f3) into master (078622c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 7a686f3 differs from pull request most recent head 896f16f. Consider uploading reports for the commit 896f16f to get more accurate results

@@            Coverage Diff             @@
##           master    #5508      +/-   ##
==========================================
+ Coverage   88.73%   88.80%   +0.06%     
==========================================
  Files         163      163              
  Lines       10670    10670              
  Branches     1818     1818              
==========================================
+ Hits         9468     9475       +7     
+ Misses        926      922       -4     
+ Partials      276      273       -3     
Impacted Files Coverage Δ
scrapy/pipelines/media.py 97.16% <ø> (ø)
scrapy/pipelines/images.py 94.78% <100.00%> (+4.34%) ⬆️
scrapy/core/downloader/__init__.py 92.48% <0.00%> (+1.50%) ⬆️

@mtabbasi mtabbasi marked this pull request as draft May 28, 2022 05:50
@mtabbasi mtabbasi marked this pull request as ready for review May 28, 2022 05:50
@kmike
Copy link
Member

kmike commented Jun 4, 2022

Thanks @mtabbasi, the PR looks good!

@kmike kmike merged commit 517cbc8 into scrapy:master Jun 4, 2022
@mtabbasi
Copy link
Contributor Author

mtabbasi commented Jun 7, 2022

My pleasure @kmike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImagesPipeline.thumb_path should allow access to item
4 participants