Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments links on project generation #552

Merged
merged 0 commits into from Oct 24, 2014
Merged

Conversation

Scorpil
Copy link
Contributor

@Scorpil Scorpil commented Jan 21, 2014

Follow up to #539 #589

Just my proposal.

I know many of you tend to agree that many users never update comments, so they may become outdated, but from my perspective it's responsibility of the user to keep comments up-to-date, and it's responsibility of the program to provide correct comments by default. So, here is my PR.

If you don't agree, just close this issue... I won't be angry, i promise. :D

@Scorpil
Copy link
Contributor Author

Scorpil commented Jan 21, 2014

Oh, and BTW, I've also corrected link in scrapy.cfg to point to scrapyd documentation (it was pointing to this page before). I think that's better, but it's your call.

@kmike
Copy link
Member

kmike commented Mar 18, 2014

I like this PR, but there is one issue: because of readthedocs/readthedocs.org#635 latest docs linked using version number are shown as outdated: check http://doc.scrapy.org/en/0.22/ vs http://doc.scrapy.org/en/latest/

@dangra
Copy link
Member

dangra commented Jul 24, 2014

the PR looks good but as @kmike pointed readthedocs/readthedocs.org#635 is a blocker IMO.

@Scorpil Scorpil force-pushed the master branch 2 times, most recently from 5cbafe2 to 5de6a11 Compare October 24, 2014 13:09
@pablohoffman pablohoffman merged commit 5de6a11 into scrapy:master Oct 24, 2014
@pablohoffman
Copy link
Member

I didn't merged this, I merged ttps://github.com/scrapy/scrapy/commit/5de6a11fda8fb51b23e25df835e which is associated with #925. No idea why github believes I merged this PR (which, btw, shows 0 commits associated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants