Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minimal versions that Scrapy is tested against, cleanup #5524

Merged
merged 4 commits into from
Jun 9, 2022
Merged

Remove minimal versions that Scrapy is tested against, cleanup #5524

merged 4 commits into from
Jun 9, 2022

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Jun 9, 2022

  • Update versions to reflect the pinned deps.
  • Tests: Remove validation for unsupported module versions.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #5524 (063b55f) into master (407562b) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 063b55f differs from pull request most recent head 197aca2. Consider uploading reports for the commit 197aca2 to get more accurate results

@@            Coverage Diff             @@
##           master    #5524      +/-   ##
==========================================
+ Coverage   88.69%   88.71%   +0.01%     
==========================================
  Files         162      162              
  Lines       10740    10740              
  Branches     1834     1834              
==========================================
+ Hits         9526     9528       +2     
+ Misses        940      939       -1     
+ Partials      274      273       -1     
Impacted Files Coverage Δ
scrapy/core/downloader/__init__.py 92.48% <0.00%> (+1.50%) ⬆️

docs/intro/install.rst Outdated Show resolved Hide resolved
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!

@Laerte Laerte requested a review from Gallaecio June 9, 2022 13:01
@Laerte Laerte changed the title Update minimal versions that Scrapy is tested against, cleanup Remove minimal versions that Scrapy is tested against, cleanup Jun 9, 2022
@Laerte Laerte requested a review from Gallaecio June 9, 2022 13:11
@kmike
Copy link
Member

kmike commented Jun 9, 2022

Thanks @Laerte!

@kmike kmike merged commit e2769cf into scrapy:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants