Skip to content

Merge values of multiple headers with same name #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

mtabbasi
Copy link
Contributor

Fixes #5515

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #5526 (892c2a4) into master (e2769cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5526   +/-   ##
=======================================
  Coverage   88.71%   88.72%           
=======================================
  Files         162      162           
  Lines       10740    10747    +7     
  Branches     1834     1835    +1     
=======================================
+ Hits         9528     9535    +7     
  Misses        939      939           
  Partials      273      273           
Impacted Files Coverage Δ
scrapy/http/headers.py 98.52% <100.00%> (+0.16%) ⬆️

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Co-authored-by: Adrián Chaves <adrian@chaves.io>
@mtabbasi mtabbasi requested a review from kmike June 20, 2022 18:17
@kmike kmike merged commit b51b52f into scrapy:master Jun 27, 2022
@kmike
Copy link
Member

kmike commented Jun 27, 2022

Thanks @mtabbasi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response.headers loses data on multiple values
3 participants