Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that the installed loop matches ASYNCIO_EVENT_LOOP #5529

Merged
merged 6 commits into from
Oct 15, 2022

Conversation

Gallaecio
Copy link
Member

I realized this was worth doing while working on #5528, but I thought it best not to make it part of that pull request.

I consider it a (minor) bug that we did not check this before, so I am not completely against adding this to 2.6, but since this is not a regression, I also do not see a reason to add this before 2.7.

@Gallaecio Gallaecio requested a review from wRAR June 14, 2022 10:50
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #5529 (26f3438) into master (22a59d0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5529      +/-   ##
==========================================
+ Coverage   88.69%   88.70%   +0.01%     
==========================================
  Files         162      162              
  Lines       10966    10977      +11     
  Branches     1796     1798       +2     
==========================================
+ Hits         9726     9737      +11     
  Misses        960      960              
  Partials      280      280              
Impacted Files Coverage Δ
scrapy/crawler.py 87.95% <100.00%> (+0.19%) ⬆️
scrapy/utils/reactor.py 79.45% <100.00%> (+2.52%) ⬆️

scrapy/utils/reactor.py Outdated Show resolved Hide resolved
Co-authored-by: Laerte Pereira <5853172+Laerte@users.noreply.github.com>
scrapy/utils/reactor.py Outdated Show resolved Hide resolved
@Gallaecio Gallaecio added this to the 2.7 milestone Jun 27, 2022
@Gallaecio Gallaecio merged commit 960a7f6 into scrapy:master Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants