make Scrapy testing suite more robust in environments where non-existing hosts are resolvable #5560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix https://github.com/scrapy/scrapy/runs/7377071488?check_suite_focus=true failure.
I've found a few places where it can be an issue, not sure if that's all of them.
Implementation is ported from Splash testing suite, where there was a similar issue - on some CI environments DNS resolution was successful for non-existing hosts.
The issue with this PR is that in the run above it only failed at one spot, not at all of them. It seems to be related to SSL. So, I'm not sure the fix in this PR is valid :)