remove compatibility code from tests for the case dataclasses module is not available #5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not available It was Python 3.6 compat code, and Python 3.6 support is dropped.
thanks flake8!
Codecov Report
@@ Coverage Diff @@
## master #5563 +/- ##
=======================================
Coverage 88.75% 88.75%
=======================================
Files 162 162
Lines 10774 10774
Branches 1843 1843
=======================================
Hits 9562 9562
Misses 939 939
Partials 273 273 |
wRAR
approved these changes
Jul 19, 2022
|
I knew, I knew that we'll see @elacuesta in this PR, he loves when code gets removed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was Python 3.6 compat code, and Python 3.6 support is dropped.
test_engine is not handled in this PR, to avoid conflicts with #5561; it's solved in f3801f1.