Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add async callbacks support to parse #5577

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

mtabbasi
Copy link
Contributor

@mtabbasi mtabbasi commented Jul 26, 2022

Fixes #5424

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #5577 (824babb) into master (737f396) will decrease coverage by 0.21%.
The diff coverage is 14.28%.

❗ Current head 824babb differs from pull request most recent head 628f53e. Consider uploading reports for the commit 628f53e to get more accurate results

@@            Coverage Diff             @@
##           master    #5577      +/-   ##
==========================================
- Coverage   88.70%   88.49%   -0.22%     
==========================================
  Files         162      162              
  Lines       10787    10796       +9     
  Branches     1851     1851              
==========================================
- Hits         9569     9554      -15     
- Misses        942      966      +24     
  Partials      276      276              
Impacted Files Coverage Δ
scrapy/commands/parse.py 28.19% <14.28%> (+0.25%) ⬆️
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️

@kmike kmike added this to the 2.7 milestone Jul 27, 2022
@mtabbasi mtabbasi changed the title add async callbacks support to parse fixes #5424 add async callbacks support to parse Jul 27, 2022
@mtabbasi mtabbasi marked this pull request as ready for review July 27, 2022 08:20
@Gallaecio
Copy link
Member

Looks good to me, but I wonder why the coverage data suggest the new test is not reaching the moved code.

@wRAR
Copy link
Member

wRAR commented Oct 13, 2022

@Gallaecio the test launches a separate scrapy parse process, and I guess coverage for subprocesses is not collected?

@Gallaecio
Copy link
Member

Indeed. I thought coverage was able to pick that up anyway, but it seems not. The same code before the changes was not in coverage either.

@Gallaecio Gallaecio merged commit 0435751 into scrapy:master Oct 15, 2022
@Gallaecio
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrapy parse doesn't support async callbacks
4 participants