Fix Feed Exporter issue with Post Processing #5581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is under discussion with @Gallaecio. |
Gallaecio
reviewed
Jul 29, 2022
|
Proposed test: felipeboffnunes#1 |
Test the life cycle of a storage file
Codecov Report
@@ Coverage Diff @@
## master #5581 +/- ##
==========================================
+ Coverage 88.84% 88.86% +0.01%
==========================================
Files 162 162
Lines 11055 11062 +7
Branches 1800 1802 +2
==========================================
+ Hits 9822 9830 +8
Misses 954 954
+ Partials 279 278 -1
|
wRAR
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5500
It fixes the issue above. It happens because when dealing with Post Processing, file is wrapped around a
PostProcessingManager, which becomes the *arg for the following procedures that will happen inFeedExporter. Those procedures believe they are handling directly the file: this is not the case when Post Processing is involved, since the file becomes an attribute of thePostProcessingManagerin these cases.We need to test this, but it's a very straightforward bug nevertheless.