-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the ability to run the -O and -t command line option together (#5516) #5605
Conversation
Additionally I added a usageError message for the case that -t and -O are used together including examples. Futhermore added a extended better deprecation warning in case -t and -o are used together including two examples. Changes to be committed: modified: scrapy/utils/conf.py
I have two inputs that I would like to get feedback on, as I do not really know how to handle the two cases. I would be very glad for your feedback.
I thank you for answering my questions and hope I could resolve this issue ok 🚀 |
extended the help message. Changes to be committed: modified: docs/topics/commands.rst modified: scrapy/commands/__init__.py
I also extended the documentation for With one caviat: Anyway, thank you for your help and feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but there are some typos, can you please fix those?
Codecov Report
@@ Coverage Diff @@
## master #5605 +/- ##
==========================================
- Coverage 88.67% 88.63% -0.04%
==========================================
Files 162 162
Lines 10998 11000 +2
Branches 1801 1802 +1
==========================================
- Hits 9752 9750 -2
- Misses 966 968 +2
- Partials 280 282 +2
|
Fix for Issue 5516
If
-t
and-O
are used together scrapy now throws ausageError
. I also created a error message including examples.Furthermore, I added an extended better deprecation warning in case
-t
and-o
are used together including two examples.