-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed incorrect info in documentation regarding the return type of parse method. #5608
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5608 +/- ##
==========================================
- Coverage 88.85% 88.66% -0.20%
==========================================
Files 162 162
Lines 10962 10962
Branches 1894 1894
==========================================
- Hits 9740 9719 -21
- Misses 942 963 +21
Partials 280 280
|
I think we have to explicitly mention (Based on RFC 2119, since we're using the word "must" in this phrase) |
…est callback method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elacuesta Are you okay with the wording here?
Thanks @zaid-ismail031! |
Fixes #5602. I could not find any other similar errors (i.e. places where it says that the return type of a
Request
callback function must only be an iterable).