Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegexLinkExtractor: encode URL unicode value when creating Links #561

Merged
merged 1 commit into from Jan 24, 2014

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Jan 23, 2014

This is rather minor but as I was working on #559 I came across this when running tests:

scrapy/link.py:16: UserWarning: Do not instantiate Link objects with unicode urls. Assuming utf-8 encoding (which could be wrong)
@kmike
Copy link
Member

@kmike kmike commented Jan 23, 2014

LGTM

dangra added a commit that referenced this pull request Jan 24, 2014
RegexLinkExtractor: encode URL unicode value when creating Links
@dangra dangra merged commit b14dabb into scrapy:master Jan 24, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@redapple redapple deleted the redapple:regexlx-encoding branch Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.