Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in tutorial #5624

Merged
merged 1 commit into from
Sep 14, 2022
Merged

fix: typo in tutorial #5624

merged 1 commit into from
Sep 14, 2022

Conversation

magsen
Copy link
Contributor

@magsen magsen commented Sep 13, 2022

fix: typo in tutorial

fix: typo in tutorial
@Gallaecio
Copy link
Member

Gallaecio commented Sep 13, 2022

I believe that is done on purpose, because in the past some people have accidentally tried to execute that on the interactive Python interpreter (>>>).

@magsen
Copy link
Contributor Author

magsen commented Sep 13, 2022

@Gallaecio Maybe but the others bash command in the same file don't have the $ sign. It is the only one.
So we must put a dollar before all bash command or none.

@Gallaecio
Copy link
Member

Oh, you are right! Well, consistency triumphs most things in my book :)

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #5624 (7b523bb) into master (3f060ae) will decrease coverage by 0.46%.
The diff coverage is 100.00%.

❗ Current head 7b523bb differs from pull request most recent head ce0ca51. Consider uploading reports for the commit ce0ca51 to get more accurate results

@@            Coverage Diff             @@
##           master    #5624      +/-   ##
==========================================
- Coverage   88.85%   88.38%   -0.47%     
==========================================
  Files         162      162              
  Lines       10962    10850     -112     
  Branches     1894     1861      -33     
==========================================
- Hits         9740     9590     -150     
- Misses        942      976      +34     
- Partials      280      284       +4     
Impacted Files Coverage Δ
scrapy/http/response/text.py 100.00% <100.00%> (ø)
scrapy/robotstxt.py 73.33% <0.00%> (-24.20%) ⬇️
scrapy/core/downloader/handlers/__init__.py 83.33% <0.00%> (-9.40%) ⬇️
scrapy/squeues.py 92.85% <0.00%> (-7.15%) ⬇️
scrapy/pqueues.py 95.86% <0.00%> (-3.31%) ⬇️
scrapy/extensions/memdebug.py 45.00% <0.00%> (-2.62%) ⬇️
scrapy/downloadermiddlewares/cookies.py 95.74% <0.00%> (-2.16%) ⬇️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️
scrapy/extensions/debug.py 44.73% <0.00%> (-1.42%) ⬇️
scrapy/extensions/throttle.py 44.89% <0.00%> (-1.11%) ⬇️
... and 62 more

@kmike kmike merged commit 681d114 into scrapy:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants