Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented how settings must be picklable #5629

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

TimothyBenger
Copy link
Contributor

@TimothyBenger TimothyBenger commented Sep 16, 2022

Resolves #5607

docs/topics/settings.rst Outdated Show resolved Hide resolved
docs/topics/settings.rst Outdated Show resolved Hide resolved
docs/topics/settings.rst Outdated Show resolved Hide resolved
Co-authored-by: Adrián Chaves <adrian@chaves.io>
@TimothyBenger
Copy link
Contributor Author

Agreed that no meaning is lost through shortening this section of information, and it's more readable this way. Made commit 1278a14 to apply the suggested changes.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #5629 (30044a4) into master (681d114) will not change coverage.
The diff coverage is n/a.

❗ Current head 30044a4 differs from pull request most recent head 9d89eec. Consider uploading reports for the commit 9d89eec to get more accurate results

@@           Coverage Diff           @@
##           master    #5629   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         162      162           
  Lines       10965    10965           
  Branches     1894     1894           
=======================================
  Hits         9722     9722           
  Misses        963      963           
  Partials      280      280           

docs/topics/settings.rst Outdated Show resolved Hide resolved
Co-authored-by: Laerte Pereira <5853172+Laerte@users.noreply.github.com>
@Gallaecio
Copy link
Member

Thanks @TimothyBenger for your work, and thanks @Laerte for your review!

@Gallaecio Gallaecio merged commit 5f19420 into scrapy:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how settings must be picklable
3 participants