CI: add Twine check in check workflow #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working action can be checked at https://github.com/armujahid/scrapy/actions/runs/3168893838/jobs/5160421545 |
kmike
reviewed
Oct 2, 2022
.github/workflows/checks.yml
Outdated
| run: | | ||
| pip install twine | ||
| python setup.py sdist | ||
| twine check dist/* |
There was a problem hiding this comment.
Could you please move this check to tox.ini, similar to other checks?
There was a problem hiding this comment.
Currently this check would be run 5 times on CI, for flake8, typing, docs, etc. tox environments. We should make it a separate tox env, and run this env on CI, similar to how others are executed.
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #5656 +/- ##
==========================================
- Coverage 88.83% 88.69% -0.15%
==========================================
Files 162 162
Lines 10964 10964
Branches 1894 1644 -250
==========================================
- Hits 9740 9724 -16
- Misses 943 960 +17
+ Partials 281 280 -1
|
|
Windows/tests CI errors are unrelated |
wRAR
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5655