Pylint issues

[marksmayo]

Tidied up .pylintrc file, removed unnecessary ignores and fixed a bunch of simple ones.

[wRAR]

Can you please look into the test failures and new flake8 messages?

[wRAR]

I think the test failure is because of the unidiomatic-typecheck "fix" (as the new code behaves differently in the case of a subclass).

[Gallaecio]

@marksmayo Do you think you will find the time to work on addressing feedback here? Otherwise, @emarondan how would you feel about taking over and finishing this change yourself?

[codecov]

Codecov Report

Merging #5677 (d384e09) into master (e2db624) will increase coverage by 0.18%.
The diff coverage is 91.08%.

@@            Coverage Diff             @@
##           master    #5677      +/-   ##
==========================================
+ Coverage   88.77%   88.95%   +0.18%     
==========================================
  Files         162      162              
  Lines       10958    10958              
  Branches     1793     1793              
==========================================
+ Hits         9728     9748      +20     
+ Misses        948      929      -19     
+ Partials      282      281       -1     

Impacted Files	Coverage Δ
scrapy/commands/__init__.py	74.71% <0.00%> (ø)
scrapy/commands/parse.py	28.19% <ø> (ø)
scrapy/core/downloader/tls.py	97.05% <ø> (ø)
scrapy/core/downloader/webclient.py	94.65% <ø> (ø)
scrapy/core/http2/protocol.py	83.41% <0.00%> (ø)
scrapy/downloadermiddlewares/httpcompression.py	92.64% <ø> (ø)
scrapy/extensions/telnet.py	81.66% <ø> (ø)
scrapy/extensions/throttle.py	46.00% <ø> (ø)
scrapy/pipelines/files.py	71.33% <0.00%> (ø)
scrapy/robotstxt.py	97.53% <ø> (+22.22%)	⬆️
... and 38 more

[wRAR]

flake8:

docs/conftest.py:15:1: E302 expected 2 blank lines, found 1
docs/utils/linkfix.py:34:9: F821 undefined name 'sys'
docs/_ext/scrapydocs.py:7:1: E302 expected 2 blank lines, found 1
scrapy/core/scraper.py:281:25: E127 continuation line over-indented for visual indent
scrapy/downloadermiddlewares/stats.py:6:1: E302 expected 2 blank lines, found 1
scrapy/downloadermiddlewares/redirect.py:60:21: E128 continuation line under-indented for visual indent
tests/test_downloadermiddleware_decompression.py:10:1: E303 too many blank lines (3)
tests/CrawlerProcess/reactor_default.py:7:1: E303 too many blank lines (3)
tests/CrawlerProcess/reactor_default_twisted_reactor_select.py:7:1: E303 too many blank lines (3)

[wRAR]

Also, as we rolled back the changes, these message classes should be put back to pylintrc:

************* Module scrapy.http.request
scrapy/http/request/__init__.py:188:11: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
************* Module tests.test_request_cb_kwargs
tests/test_request_cb_kwargs.py:94:31: C1803: 'kwargs == {}' can be simplified to 'not kwargs' as an empty sequence is falsey (use-implicit-booleaness-not-comparison)

[marksmayo]

Apologies, it's been a busy few weeks. Looking now

[marksmayo]

@Gallaecio are you able to kick off the workflows, to see if any issues are left after I've resynched and fixed? Thanks.

[marksmayo]

Thanks for your help! Was a bit of a big one to bite off for my first go, in hindsight

[Gallaecio]

Some import sorting and grouping changes like this one look wrong to me, but I am OK with merging this as an overall improvement, and in a separate pull request introduce a CI job to check these with isort, and include isort into the pre-commit configuration that we may introduce in #5734.

[Gallaecio]

Just a tip for the future: using single quotes (':') would have worked as well to move netloc.split(":")[0] into the f-string.

[Gallaecio]

Thanks!