-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace indentation of source before parsing with ast. #5691
Replace indentation of source before parsing with ast. #5691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for this?
Codecov Report
@@ Coverage Diff @@
## master #5691 +/- ##
==========================================
+ Coverage 88.64% 88.66% +0.02%
==========================================
Files 162 162
Lines 10986 10995 +9
Branches 1798 1799 +1
==========================================
+ Hits 9738 9749 +11
+ Misses 967 966 -1
+ Partials 281 280 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few suggestions. Thanks!
- compile regex - readability improvements
closes #5323
Replace starting indentation with pattern
(^[\t ]+)
and replace the matching indentation in other lines.