Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deprecated warning with try except block #5692

Conversation

iamkaushal
Copy link
Contributor

fixes #5684
Using try except block to support backward compablility of order version of Pillow. It can we removed when the minimum requirement of Pillow is updated.

scrapy/pipelines/images.py Outdated Show resolved Hide resolved
scrapy/pipelines/images.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #5692 (d44a8ba) into master (b33244e) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head d44a8ba differs from pull request most recent head 8a15eb6. Consider uploading reports for the commit 8a15eb6 to get more accurate results

@@            Coverage Diff             @@
##           master    #5692      +/-   ##
==========================================
- Coverage   88.64%   88.56%   -0.08%     
==========================================
  Files         162      162              
  Lines       10986    10988       +2     
  Branches     1798     1617     -181     
==========================================
- Hits         9738     9732       -6     
- Misses        967      974       +7     
- Partials      281      282       +1     
Impacted Files Coverage Δ
scrapy/pipelines/images.py 94.95% <100.00%> (+0.17%) ⬆️
scrapy/core/downloader/handlers/__init__.py 83.63% <0.00%> (-9.10%) ⬇️
scrapy/downloadermiddlewares/cookies.py 95.78% <0.00%> (-2.11%) ⬇️
scrapy/shell.py 67.96% <0.00%> (-0.79%) ⬇️
scrapy/http/response/__init__.py 97.43% <0.00%> (-0.04%) ⬇️
scrapy/http/request/__init__.py 97.77% <0.00%> (-0.03%) ⬇️
scrapy/utils/python.py 88.46% <0.00%> (ø)
scrapy/commands/check.py 71.01% <0.00%> (ø)

@Gallaecio
Copy link
Member

Thanks!

@Gallaecio Gallaecio merged commit f4e2a10 into scrapy:master Oct 25, 2022
@kmike kmike added this to the Scrapy 2.7.1 milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: ANTIALIAS is deprecated
4 participants