CrawlSpider: pass cb_kwargs from process_request #5699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CrawlSpider._callback
is not passing any keyword arguments it might receive toCrawlSpider._parse_response
.I'm currently giving priority to the arguments set in
process_request
over the ones set in the rule, this could be open to discussion.Missing tests, will add them soon.AddedSample spider:
Without this patch, at 9077d0f (latest
master
branch)After this patch: