Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrapy -h outputs a stray commands #5709 #5711

Closed
wants to merge 1 commit into from

Conversation

Jtwoolbright
Copy link

init.py was being passed as a module from scrapy/commands when walk_modules was called from function def _iter_command_classes in cmdline.py

@wRAR wRAR linked an issue Nov 10, 2022 that may be closed by this pull request
@wRAR
Copy link
Member

wRAR commented Nov 10, 2022

Thanks for finding the issue! I think changing the behavior of walk_modules is not a correct fix here though, as I think it changes its behavior and the docstring describes the current one. Removing the incorrect module from the list in the command-related code is better, I think.

@wRAR
Copy link
Member

wRAR commented Nov 10, 2022

And it indeed breaks tests (can you please run tests locally before publishing next time?).

@Laerte Laerte mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrapy -h outputs a stray "commands"
2 participants