Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stray commands #5712

Merged
merged 2 commits into from
Nov 10, 2022
Merged

fix: stray commands #5712

merged 2 commits into from
Nov 10, 2022

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Nov 10, 2022

This behaviour was introduced on: #4552

We created a new class that inherit from ScrapyCommand but forget to check on _iter_command_classes function, this is the reason that command was appearing loose.

Close: #5711, Fixes: #5709

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #5712 (c6c60e6) into master (bbe24d7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c6c60e6 differs from pull request most recent head a55f8f7. Consider uploading reports for the commit a55f8f7 to get more accurate results

@@            Coverage Diff             @@
##           master    #5712      +/-   ##
==========================================
- Coverage   88.87%   88.85%   -0.02%     
==========================================
  Files         162      162              
  Lines       11026    11026              
  Branches     1808     1808              
==========================================
- Hits         9799     9797       -2     
- Misses        947      948       +1     
- Partials      280      281       +1     
Impacted Files Coverage Δ
scrapy/cmdline.py 67.96% <100.00%> (ø)
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

@Gallaecio
Copy link
Member

Great!

@Gallaecio Gallaecio merged commit ae3fd01 into scrapy:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrapy -h outputs a stray "commands"
3 participants