Remove support for override settings with SCRAPY_ environment variables
#5724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5724 +/- ##
==========================================
- Coverage 88.74% 88.74% -0.01%
==========================================
Files 162 162
Lines 10973 10969 -4
Branches 1801 1799 -2
==========================================
- Hits 9738 9734 -4
Misses 954 954
Partials 281 281
|
You’ll get no complaints from me! |
Gallaecio
approved these changes
Nov 22, 2022
wRAR
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another cleanup. 🧹 (Last one this week i promise 🤞🏻 )
We could change the
valid_envvarsand appendSCRAPY_prefix, but i choose to leave the dictionary intact and just add another condition to if statement, changed tests accordingly.