Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better language surrounding logging #5727

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

JazzGlobal
Copy link
Contributor

Fixes outstanding comments within #5722

  1. Changed comments referencing "Current" memory usage to "Peak".
  2. Changed comments referencing "M" to "MiB" where applicable.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #5727 (bdc0bca) into master (aac6103) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5727      +/-   ##
==========================================
- Coverage   88.74%   88.74%   -0.01%     
==========================================
  Files         162      162              
  Lines       10973    10969       -4     
  Branches     1801     1799       -2     
==========================================
- Hits         9738     9734       -4     
  Misses        954      954              
  Partials      281      281              
Impacted Files Coverage Δ
scrapy/extensions/memusage.py 48.91% <0.00%> (ø)
scrapy/utils/project.py 78.43% <0.00%> (-1.57%) ⬇️

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wRAR wRAR merged commit 0417e3e into scrapy:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants