Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noconnect deprecate code #5731

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Remove noconnect deprecate code #5731

merged 1 commit into from
Nov 23, 2022

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Nov 23, 2022

I was in doubt about how to approach this one, so i basically remove all logic that depends upon omitConnectTunnel, maybe should we also pop the b'noconnect parameter?

@wRAR
Copy link
Member

wRAR commented Nov 23, 2022

The logic change looks correct. Not sure about removing the param, is it removed by the current code?

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #5731 (e769532) into master (45c2bd7) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5731      +/-   ##
==========================================
- Coverage   88.73%   88.70%   -0.03%     
==========================================
  Files         162      162              
  Lines       10964    10953      -11     
  Branches     1799     1797       -2     
==========================================
- Hits         9729     9716      -13     
- Misses        954      955       +1     
- Partials      281      282       +1     
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/http11.py 93.97% <100.00%> (-0.12%) ⬇️
scrapy/core/downloader/handlers/http2.py 100.00% <100.00%> (ø)
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

@Laerte
Copy link
Member Author

Laerte commented Nov 23, 2022

@wRAR Is not, i just asked because i was unsure if passing the proxyParams with ?noconnect could break something but since we not support anymore i think is not a problem.

@Laerte
Copy link
Member Author

Laerte commented Nov 23, 2022

The error in Windows / tests (3.10, asyncio) seems unrelated with the change.

@Gallaecio
Copy link
Member

The error in Windows / tests (3.10, asyncio) seems unrelated with the change.

Rerunning now…

@wRAR wRAR merged commit 04a1a4b into scrapy:master Nov 23, 2022
@Laerte Laerte deleted the remove-noconnect-deprecate-code branch November 23, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants