Remove unnecessary backwards compatibility comments #5732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5732 +/- ##
==========================================
- Coverage 88.95% 88.79% -0.17%
==========================================
Files 162 162
Lines 10938 10938
Branches 1797 1797
==========================================
- Hits 9730 9712 -18
- Misses 927 945 +18
Partials 281 281
|
wRAR
approved these changes
Nov 24, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5726. The code seems to still be in use and is being invoked therefore, we can remove the backwards compatibility comment since it is part of the feature still. I didn't come across any code that would suggest this use-case will never be executed.