Skip to content

Add a comment about tmpname + '^'. #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Nov 25, 2022

I had no idea why is this needed and how should it be used (https://github.com/scrapy/scrapy/pull/5285/files#r844017508, https://github.com/scrapy/scrapy/pull/5682/files/726680c7125ab3a6622b12e25d45dbfedc5a39b3#r1027288466) so I tracked it down to 3012030 and added this comment.

This was referenced Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #5736 (face18b) into master (0417e3e) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head face18b differs from pull request most recent head f85c3f3. Consider uploading reports for the commit f85c3f3 to get more accurate results

@@            Coverage Diff             @@
##           master    #5736      +/-   ##
==========================================
- Coverage   88.95%   88.77%   -0.19%     
==========================================
  Files         162      162              
  Lines       10938    10931       -7     
  Branches     1797     1620     -177     
==========================================
- Hits         9730     9704      -26     
- Misses        927      943      +16     
- Partials      281      284       +3     
Impacted Files Coverage Δ
scrapy/utils/conf.py 92.10% <ø> (ø)
scrapy/core/downloader/handlers/__init__.py 83.63% <0.00%> (-9.10%) ⬇️
scrapy/utils/test.py 60.27% <0.00%> (-5.48%) ⬇️
scrapy/squeues.py 95.34% <0.00%> (-4.66%) ⬇️
scrapy/downloadermiddlewares/cookies.py 95.78% <0.00%> (-2.11%) ⬇️
scrapy/pipelines/images.py 95.58% <0.00%> (-1.48%) ⬇️
scrapy/shell.py 67.96% <0.00%> (-0.79%) ⬇️
scrapy/core/http2/protocol.py 82.91% <0.00%> (-0.51%) ⬇️
scrapy/utils/python.py 90.90% <0.00%> (-0.06%) ⬇️
scrapy/utils/defer.py 97.29% <0.00%> (-0.04%) ⬇️
... and 5 more

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wRAR wRAR merged commit 3be7aa9 into scrapy:master Nov 25, 2022
@wRAR wRAR deleted the test-char-comment branch November 25, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants