fix test_follow_whitespace_* tests #5756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5756 +/- ##
==========================================
- Coverage 88.91% 84.81% -4.11%
==========================================
Files 162 162
Lines 10963 10963
Branches 1794 1794
==========================================
- Hits 9748 9298 -450
- Misses 932 1394 +462
+ Partials 283 271 -12
|
Gallaecio
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
The old behavior is a bug.
For example, if you open the following HTML file in Chromium or Firefox, both links point to the same URL, because the contents of the href attribute are parsed according to the URL living standard, which mandates stripping certain characters before even parsing the URL.
<a href="foo">Without a space</a><br/>
<a href="foo ">With a space</a>So, rather than changing expectations, I would use a conditional, strict xfail instead. e.g.
@pytest.mark.xfail(
parse_version(w3lib_version) < parse_version("2.1.1"),
reason="https://github.com/scrapy/w3lib/pull/207",
strict=True,
)No strong opinion though, I am OK with merging as is.
PS: From what I can tell, all remaining CI errors are unrelated to this change.
wRAR
approved these changes
Dec 12, 2022
holymonson
added a commit
to holymonson/scrapy-feedstock
that referenced
this pull request
Jan 3, 2023
Should be released after scrapy/scrapy#5756 released.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are failing because after release 2.1.1, w3lib is striping spaces from url, so i add a validation to append
%20if the version that is running is minor than 2.1.1.resolves #5750