Spelling #5764
Merged
Spelling #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Dec 19, 2022
| - replace unencodable codepoints with html entities. fixes #562 and #285 (:commit:`5f87b17`) | ||
| - replace unencodeable codepoints with html entities. fixes #562 and #285 (:commit:`5f87b17`) |
There was a problem hiding this comment.
some projects don't like changing changelogs.
I'm trying to be fairly conservative about my changes..
Comment on lines
-597
to
+608
| def __init__(self, parslet_json_code): | ||
| parslet = json.loads(parselet_json_code) | ||
| def __init__(self, parsley_json_code): | ||
| parsley = json.loads(parselet_json_code) | ||
| class ParsleyItem(Item): | ||
| def __init__(self, *a, **kw): | ||
| for name in parslet.keys(): | ||
| for name in parsley.keys(): | ||
| self.fields[name] = Field() | ||
| super(ParsleyItem, self).__init__(*a, **kw) | ||
| self.item_class = ParsleyItem | ||
| self.parsley = PyParsley(parslet, output='python') | ||
| self.parsley = PyParsley(parsley, output='python') | ||
|
|
||
| def process_response(self, response, request, spider): | ||
| return self.item_class(self.parsly.parse(string=response.body)) | ||
| return self.item_class(self.parsley.parse(string=response.body)) |
Codecov Report
@@ Coverage Diff @@
## master #5764 +/- ##
==========================================
+ Coverage 84.82% 84.84% +0.01%
==========================================
Files 162 162
Lines 10974 10974
Branches 1795 1795
==========================================
+ Hits 9309 9311 +2
+ Misses 1394 1393 -1
+ Partials 271 270 -1
|
Gallaecio
approved these changes
Jan 11, 2023
| @@ -316,7 +316,7 @@ def _make_read_only(path: Path): | |||
| self.assertEqual(actual_permissions, expected_permissions) | |||
|
|
|||
| def test_startproject_permissions_unchanged_in_destination(self): | |||
| """Check that pre-existing folders and files in the destination folder | |||
| """Check that preexisting folders and files in the destination folder | |||
There was a problem hiding this comment.
This one seems arguable, but no strong opinion either way.
Same applies to “nonexistent” later on.
|
Closing and reopening to re-trigger CI jobs… |
wRAR
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/scrapy/actions/runs/3727974993
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/scrapy/actions/runs/3727977653
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.