Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate direct invocation of setup.py #5776

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Deprecate direct invocation of setup.py #5776

merged 1 commit into from
Dec 31, 2022

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Dec 30, 2022

Closes #5774

We don't need to install setuptools and wheel packages anymore in publish workflow because build create a virtual environment in order to build the package. We don't need to pass any argument to build command because the default behaviour already create a wheel/source distribution

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #5776 (577001c) into master (7ae32ea) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5776      +/-   ##
==========================================
+ Coverage   84.82%   84.84%   +0.01%     
==========================================
  Files         162      162              
  Lines       10974    10974              
  Branches     1795     1795              
==========================================
+ Hits         9309     9311       +2     
+ Misses       1394     1393       -1     
+ Partials      271      270       -1     
Impacted Files Coverage Δ
scrapy/core/downloader/__init__.py 92.48% <0.00%> (+1.50%) ⬆️

@wRAR
Copy link
Member

wRAR commented Dec 30, 2022

I guess checking the publish action can only be done during the next release preparation :)

@Gallaecio Gallaecio merged commit deaf1fb into scrapy:master Dec 31, 2022
@Gallaecio
Copy link
Member

Thanks!

@Laerte Laerte deleted the deprecate-direct-invocation-of-setup.py branch December 31, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate direct invocation of setup.py
3 participants