Skip to content

Fix test_pinned_twisted_version #5780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2023
Merged

Fix test_pinned_twisted_version #5780

merged 1 commit into from
Jan 2, 2023

Conversation

Gallaecio
Copy link
Member

Partial fix for #5749

@Gallaecio Gallaecio marked this pull request as draft January 2, 2023 12:46
@Gallaecio
Copy link
Member Author

Gallaecio commented Jan 2, 2023 •
edited
Loading

6084e8f fixes an issue I introduced in bb72bba where pinned versions would install package dependencies with the --update parameter passed to pip, hence upgrading the versions specified in Tox‘s deps, which seems to have become an issue with the latest Tox (maybe earlier versions would install deps after the package, so there was no issue?).

@Gallaecio
Copy link
Member Author

Oh my… FAILED tests/test_utils_display.py::TestDisplay::test_pformat…

Please, CI, give me a break. You breaking faster than we can fix you is not sustainable 😓

@Gallaecio
Copy link
Member Author

Jokes aside, test_pinned_twisted_version seems fixed now.

@Gallaecio Gallaecio marked this pull request as ready for review January 2, 2023 13:36
@wRAR wRAR merged commit 80d35a7 into scrapy:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gallaecio @wRAR