Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OrderedDict to dict #5795

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Replace OrderedDict to dict #5795

merged 2 commits into from
Jan 17, 2023

Conversation

serhii73
Copy link
Collaborator

@serhii73 serhii73 commented Jan 16, 2023

Since version 3.7, it makes no sense to use OrderedDict because python keeps data in dictionaries in order. Ordinary dictionaries are fastest than OrderedDict

@Gallaecio Gallaecio merged commit caaeb23 into scrapy:master Jan 17, 2023
@serhii73 serhii73 deleted the improve/dict branch January 17, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants