Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set FEED_EXPORT_ENCODING='utf-8' in the default template #5800

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Set FEED_EXPORT_ENCODING='utf-8' in the default template #5800

merged 3 commits into from
Jan 20, 2023

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Jan 19, 2023

Resolves #5797

@codecov
Copy link

codecov bot commented Jan 19, 2023 •
edited
Loading

Codecov Report

Merging #5800 (b611848) into master (f449ee5) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5800      +/-   ##
==========================================
- Coverage   88.93%   88.91%   -0.02%     
==========================================
  Files         162      162              
  Lines       10988    10988              
  Branches     1797     1797              
==========================================
- Hits         9772     9770       -2     
- Misses        937      938       +1     
- Partials      279      280       +1
Impacted Files Coverage Δ
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

@wRAR
Copy link
Member

wRAR commented Jan 20, 2023

The idea was to add it to the project template, not change the default :) Sorry if that wasn't clear.

@Laerte
Copy link
Member Author

Laerte commented Jan 20, 2023 •
edited
Loading

@wRAR Understood! Sorry, check now!

wRAR
wRAR reviewed Jan 20, 2023
View reviewed changes
docs/topics/feed-exports.rst Outdated Show resolved Hide resolved
wRAR
wRAR reviewed Jan 20, 2023
View reviewed changes
docs/topics/feed-exports.rst Outdated Show resolved Hide resolved
@wRAR wRAR merged commit 9cb757d into scrapy:master Jan 20, 2023
@Laerte Laerte deleted the chore/feed-export-encoding branch January 20, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

@Gallaecio Gallaecio Gallaecio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set FEED_EXPORT_ENCODING="utf-8" in the default template
3 participants
@Laerte @wRAR @Gallaecio