Simplify Publish workflow

[Laerte]

Simplify publish workflow by using official PyPI publish action.

[codecov]

Codecov Report

Merging #5802 (4a424ad) into master (9cb757d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5802      +/-   ##
==========================================
+ Coverage   88.93%   88.94%   +0.01%     
==========================================
  Files         162      162              
  Lines       10988    11002      +14     
  Branches     1797     1798       +1     
==========================================
+ Hits         9772     9786      +14     
  Misses        937      937              
  Partials      279      279              

Impacted Files	Coverage Δ
scrapy/item.py	98.36% <0.00%> (ø)
scrapy/link.py	100.00% <0.00%> (ø)
scrapy/mail.py	78.65% <0.00%> (ø)
scrapy/shell.py	68.65% <0.00%> (ø)
scrapy/cmdline.py	67.96% <0.00%> (ø)
scrapy/crawler.py	87.17% <0.00%> (ø)
scrapy/pqueues.py	99.17% <0.00%> (ø)
scrapy/squeues.py	100.00% <0.00%> (ø)
scrapy/__init__.py	84.21% <0.00%> (ø)
scrapy/resolver.py	92.20% <0.00%> (ø)
... and 128 more

[Laerte]

💡 We could even simplify this workflow:

name: Publish
on:
  push:
    tags:
      - '[0-9]+.[0-9]+.[0-9]+'
      - '[0-9]+.[0-9]+.[0-9]+rc[0-9]+' # Release Candidate
      - '[0-9]+.[0-9]+.[0-9]+.dev[0-9]+' # Development

jobs:
  publish:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-python@v4
        with:
          python-version: 3.11
      - run: | 
          pip install --upgrade build twine
          python -m build
      - name: Publish to PyPI
        uses: pypa/gh-action-pypi-publish@release/v1
        with:
          password: ${{ secrets.PYPI_TOKEN }}

With this we can remove the Check Tag step and this action will be only executed when we push a new tag that matches our pattern.

[Gallaecio]

Thanks!

[Gallaecio]

The proposed simplification also sounds good to me. In fact, we haven’t released an rc or dev version in years, and I don’t expect us to do so any time soon, so we could even remove those 2 patterns as well.

[Laerte]

@Gallaecio I pushed the refactor, i also use the same workflow on my personal project: https://github.com/Laerte/aes_pkcs5/blob/main/.github/workflows/publish.yml and works flawless!

[Gallaecio]

❤️

[kmike]

Thanks @Laerte!