-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Upgrade CI tools #5823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CI tools #5823
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5823 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 162 162
Lines 11002 11002
Branches 1798 1798
=======================================
Hits 9786 9786
Misses 937 937
Partials 279 279
|
Note: Whichever gets merged first, this or #5816, requires the other pull request to be updated accordingly to have black versions match. |
@@ -4,7 +4,7 @@ | |||
# and then run "tox" from this directory. | |||
|
|||
[tox] | |||
envlist = security,flake8,black,typing,py | |||
envlist = pre-commit,pylint,typing,py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include pre-commit to github actions "checks" workflow? Any other changes needed to the workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already run pre-commit in GitHub (without tox).
Since the pre-commit configuration freezes versions at the pre-commit level, and all other checks use tox, I don’t think we need anything else.
Thanks @Gallaecio! |
Includes:
class
/def
lines.