Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated BadZipfile with BadZipFile #5849

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Mar 12, 2023

BadZipfile (with a small f) has been deprecated since Python 3.2, use BadZipFile (big F) instead, added in 3.2.

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #5849 (834140f) into master (afafc27) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 834140f differs from pull request most recent head dbc3e04. Consider uploading reports for the commit dbc3e04 to get more accurate results

@@           Coverage Diff           @@
##           master    #5849   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         162      162           
  Lines       11043    11043           
  Branches     1799     1799           
=======================================
  Hits         9817     9817           
  Misses        948      948           
  Partials      278      278           
Impacted Files Coverage Δ
scrapy/downloadermiddlewares/decompression.py 100.00% <100.00%> (ø)

@Gallaecio Gallaecio merged commit 9411cf4 into scrapy:master Mar 13, 2023
@Gallaecio
Copy link
Member

Thanks!

@hugovk hugovk deleted the replace-deprecated-BadZipFile branch March 13, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants