Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call SSL_get_server_tmp_key() if not available. #5858

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Mar 24, 2023

Fixes #5857

@wRAR wRAR added the bug label Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #5858 (591bb3c) into master (d60b4ed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5858      +/-   ##
==========================================
+ Coverage   88.84%   88.85%   +0.01%     
==========================================
  Files         162      162              
  Lines       11055    11057       +2     
  Branches     1800     1801       +1     
==========================================
+ Hits         9822     9825       +3     
  Misses        954      954              
+ Partials      279      278       -1     
Impacted Files Coverage Δ
scrapy/utils/ssl.py 57.50% <100.00%> (+2.23%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@Laerte Laerte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Gallaecio Gallaecio merged commit ada9173 into master Mar 27, 2023
@wRAR wRAR deleted the tls-logging-fix branch April 8, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS logging broken with new cryptography
3 participants