Skip to content

Fix: Uncaught ReferenceError: analytics is not defined #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

jxlil
Copy link
Contributor

@jxlil jxlil commented Mar 28, 2023

@Gallaecio A rollback was performed on the code. However, the new domain was kept.

Closes #5875

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #5877 (d3f6bba) into master (ada9173) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head d3f6bba differs from pull request most recent head 2c31aa6. Consider uploading reports for the commit 2c31aa6 to get more accurate results

@@            Coverage Diff             @@
##           master    #5877      +/-   ##
==========================================
- Coverage   88.85%   88.83%   -0.03%     
==========================================
  Files         162      162              
  Lines       11057    11057              
  Branches     1801     1801              
==========================================
- Hits         9825     9822       -3     
- Misses        954      957       +3     
  Partials      278      278              

see 1 file with indirect coverage changes

@Gallaecio
Copy link
Member

Gallaecio commented Mar 28, 2023

I think that part of the code was deleted on purpose.

I think the solution here is to either unwrap those ga calls so that they are not defined on a callback of a method from the (now deleted) analytics object, or to delete this layout template override altogether, ga calls included.

Deleting the file altogether may be best, I think.

@jxlil
Copy link
Contributor Author

jxlil commented Mar 28, 2023

It seems that Segment is no longer being used (#5072 (comment)). I think the best thing would be to delete the file.

@Gallaecio Gallaecio marked this pull request as ready for review March 28, 2023 07:17
@wRAR wRAR merged commit 4dacad0 into scrapy:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken JavaScript reference in the docs
3 participants