Skip to content

Fixed Docs Makefile to open build/html/index.html in browser(#5878) #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xt1033
Copy link

@xt1033 xt1033 commented Mar 28, 2023

Fixes #5878

PR for modifying Makefile to open build/html/index.html
Path.resolve() was returning the PosixPath class so it was not possible to concatenate it with a string.
as_uri() converts the PosixPath to a string and makes it possible to concatenate it to a string which opens "build/html/index.html" in the browser.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #5879 (2686535) into master (4dacad0) will not change coverage.
The diff coverage is n/a.

❗ Current head 2686535 differs from pull request most recent head 46bb7b3. Consider uploading reports for the commit 46bb7b3 to get more accurate results

@@           Coverage Diff           @@
##           master    #5879   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         162      162           
  Lines       11057    11057           
  Branches     1801     1801           
=======================================
  Hits         9825     9825           
  Misses        954      954           
  Partials      278      278           

@wRAR wRAR merged commit 4249fc6 into scrapy:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrapy docs: 'make htmlview' does not work
3 participants