Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing slash in selecting dynamically-loaded content documentation #5890

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

dashtinejad
Copy link
Contributor

@dashtinejad dashtinejad commented Apr 9, 2023

I've been reading scrapy documentation and I've realized that a slash is missing in one of the examples. This PR adds the missing slash in the "selecting dynamically-loaded content" documentation.

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #5890 (48a98bb) into master (c34ca4a) will decrease coverage by 0.09%.
The diff coverage is 86.99%.

❗ Current head 48a98bb differs from pull request most recent head a71eadb. Consider uploading reports for the commit a71eadb to get more accurate results

@@            Coverage Diff             @@
##           master    #5890      +/-   ##
==========================================
- Coverage   88.94%   88.85%   -0.09%     
==========================================
  Files         162      162              
  Lines       11002    11057      +55     
  Branches     1798     1801       +3     
==========================================
+ Hits         9786     9825      +39     
- Misses        937      954      +17     
+ Partials      279      278       -1     
Impacted Files Coverage Δ
scrapy/commands/__init__.py 74.71% <ø> (ø)
scrapy/commands/bench.py 100.00% <ø> (ø)
scrapy/commands/crawl.py 60.00% <ø> (ø)
scrapy/commands/edit.py 51.85% <ø> (ø)
scrapy/commands/fetch.py 89.13% <ø> (ø)
scrapy/commands/list.py 77.77% <ø> (ø)
scrapy/commands/runspider.py 93.47% <ø> (ø)
scrapy/commands/settings.py 71.87% <ø> (ø)
scrapy/commands/shell.py 92.85% <ø> (ø)
scrapy/commands/startproject.py 100.00% <ø> (ø)
... and 46 more

... and 1 file with indirect coverage changes

@Gallaecio Gallaecio merged commit 98571eb into scrapy:master Apr 10, 2023
@Gallaecio
Copy link
Member

Thanks!

@dashtinejad dashtinejad deleted the patch-1 branch May 8, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants